Harden radio save_other_choice lookup for JSON fields#382
Open
meravi wants to merge 2 commits into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
left a comment
cbravobernal
left a comment
Contributor
There was a problem hiding this comment.
Verified locally:
- The two new tests reproduce the reported warning against current trunk (
Undefined array key "ID"inclass-acf-field-radio.php:347) and pass with this fix. - Full PHPUnit suite (2230 tests), PHPStan, and phpcs all green on this branch.
The defensive selector build (ID → key → bail) and the acf_get_field() return check both look right, and behavior for valid persisted fields is unchanged.
Verification run via Claude Code, reviewed by @cbravobernal.
cbravobernal
force-pushed
the
fix/radio-save-other-choice-guards
branch
from
60fac64 to
7e8ff26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens
acf_field_radio::update_value()whensave_other_choiceis enabled and the runtime field is JSON-only or missing identifiers.Changes
ID->key-> bail early).acf_get_field()fails or returns a field without DBID.choicesto an array before appending custom values.Tests
test_update_value_save_other_choice_handles_json_field_without_idtest_update_value_save_other_choice_handles_missing_field_identifierFixes #381